Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab expansion for non-ASCII file paths #403

Merged
merged 3 commits into from
Feb 7, 2017
Merged

Fix tab expansion for non-ASCII file paths #403

merged 3 commits into from
Feb 7, 2017

Conversation

dahlbyk
Copy link
Owner

@dahlbyk dahlbyk commented Feb 6, 2017

Fix #64 now that #359 and #397 have fixed the encoding issue I encountered at the time.

non-ascii-paths

cc @haacked

@dahlbyk dahlbyk added this to the v0.7 milestone Feb 6, 2017
Copy link
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add this to the CHANGELOG.md. :-)

@dahlbyk
Copy link
Owner Author

dahlbyk commented Feb 6, 2017

Don't forget to add this to the CHANGELOG.md. :-)

Do I fail at reading comprehension, or does CHANGELOG (even after #402) not mention the other encoding fixes either? Regardless, to avoid conflicts I'll add a note about this to #402 after this gets merged.

@dahlbyk
Copy link
Owner Author

dahlbyk commented Feb 6, 2017

@rkeithhill do you think we would be able to reasonably test this particularly quote/encoding round-trip?

@rkeithhill
Copy link
Collaborator

Do I fail at reading comprehension, or does CHANGELOG (even after #402) not mention the other encoding fixes either

I suspect not. ;-) I added stuff I found but no guarantees that I found everything.

do you think we would be able to reasonably test this particularly quote/encoding round-trip?

Not sure. Would have to experiment with it.

@dahlbyk
Copy link
Owner Author

dahlbyk commented Feb 7, 2017

Figured out a failing test that is made to pass:

   Context Add/Reset/Checkout TabExpansion Tests
    [-] Tab completes non-ASCII file name 782ms
      at <ScriptBlock>, C:\Dev\OSS\posh-git\test\TabExpansion.Tests.ps1: line 144
      Expected string length 12 but was 25. Strings differ at index 0.
      Expected: {posh�git.txt}
      But was:  {"posh\342\200\242git.txt"}
      -----------^
      144:             $result | Should BeExactly 'posh�git.txt'

Oddly, VS Code is showing Expected: {poshgit.txt} (i.e the UTF-8 bullet is invisble) when it should be Expected: {posh•git.txt}, but it seems to work. ¯\_(ツ)_/¯

Copy link
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM.

@dahlbyk dahlbyk merged commit 2f92ba6 into master Feb 7, 2017
@dahlbyk dahlbyk deleted the quotepath branch February 7, 2017 03:10
@dahlbyk dahlbyk mentioned this pull request Mar 26, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with tab expansion and non-English file names
2 participants